Skip to content

updates to resid at surface #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pmocz wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

updates to resid at surface #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fe91a5
test new resid, scale fixed at beginning
pmocz Dec 4, 2025
59be280
[ci optional] address thermohaline, full test
Debraheem Dec 5, 2025
36d38f7
[ci optional] full test
Debraheem Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions star/private/hydro_eqns.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1003,8 +1003,8 @@ subroutine set_Tsurf_BC(ierr)
integer, intent(out) :: ierr
logical :: test_partials
type(auto_diff_real_star_order1) :: &
lnT1_ad, dT4_dm, T4_p1, T4_surf, T4_00_actual, T4_00_expected, scale
real(dp) :: residual
lnT1_ad, dT4_dm, T4_p1, T4_surf, T4_00_actual, T4_00_expected
real(dp) :: residual, scale
include 'formats'
!test_partials = (1 == s% solver_test_partials_k)
test_partials = .false.
Expand All @@ -1018,7 +1018,7 @@ subroutine set_Tsurf_BC(ierr)
resid_ad = T4_00_expected/T4_00_actual - 1d0
else
lnT1_ad = wrap_lnT_00(s,1)
scale = max(1d0,lnT1_ad)
scale = max(1d0,s%lnT_start(1))
resid_ad = (lnT_bc_ad - lnT1_ad)/scale
end if
residual = resid_ad%val
Expand All @@ -1045,13 +1045,14 @@ end subroutine set_Tsurf_BC
subroutine set_Psurf_BC(ierr)
integer, intent(out) :: ierr
logical :: test_partials
type(auto_diff_real_star_order1) :: lnP1_ad, scale
type(auto_diff_real_star_order1) :: lnP1_ad
real(dp) :: scale
include 'formats'
!test_partials = (1 == s% solver_test_partials_k)
test_partials = .false.
ierr = 0
lnP1_ad = wrap_lnPeos_00(s,1)
scale = max(1d0,lnP1_ad)
scale = max(1d0,s%lnPeos_start(1))
resid_ad = (lnP_bc_ad - lnP1_ad)/scale
s% equ(i_P_eqn, 1) = resid_ad%val
if (test_partials) then
Expand Down
2 changes: 1 addition & 1 deletion star/test_suite/1M_thermohaline/inlist_1M_thermohaline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
trace_history_value_name(3) = 'he_core_mass'

! limit max_model_number as part of test_suite
max_model_number = 6500
max_model_number = 7000

initial_mass = 1.0
initial_z = 2d-2
Expand Down