Enables tag batch editing (exportable/hidden) #3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iglocska
requested changes
Sep 10, 2018
| throw new NotFoundException('You don\'t have permission to do that.'); | ||
| } | ||
| $tag_ids = json_decode($this->request->data['Tag']['tag_ids']); | ||
| $tags = $this->Tag->find('all', array( |
There was a problem hiding this comment.
best to introduce a check here for empty $tag_ids, just in case so it doesn't find every exisitng tag.
app/Controller/TagsController.php
Outdated
| 'recursive' => -1, | ||
| )); | ||
|
|
||
| $hidden = $this->request->data['Tag']['hidden']; |
There was a problem hiding this comment.
Check for empty, user might be coming from the API and not set that field
ancailliau
force-pushed
the
batch-tag-edit
branch
from
d00aff3 to
ba42987
Compare
|
The PR is updated according the comments. |
|
@iglocska Up, as discussed yesterday :) |
|
Tested NOT working. You select tags, toggle them in the new UI and nothing happens. Perhaps some things have changed since September 2018. Will take a quick look later on. |
|
@ancailliau any upates on this PR? |
|
Sorry, I was abroad. I will check and update asap. Thx for the reminder. |
adulau
added
S: not reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exportable and hidden flag can be edited in batch, from the tag list page.
Release Type: Minor