Updated deploy production branch note #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @SichengH! I'm adding a couple of minor points to the file. |
briangow
reviewed
Apr 15, 2022
briangow
reviewed
Apr 15, 2022
|
|
||
| Run command: `git push mimic-production` | ||
|
|
||
|
|
There was a problem hiding this comment.
I thought you were going to add an "Expected errors" section. I think we can wait to fix the errors until someone has some extra time. If you are getting errors and the deployment is still working, I think it's best to mention them here though.
There was a problem hiding this comment.
@SichengH , I see your update but it's better to give some specific keywords from the expected errors that we are getting. Is this possible?
SichengH
force-pushed
the
update_deploy_readme
branch
from
cfa45a8 to
344fd47
Compare
|
isn't this better for the lcp wiki? that way it's not awkwardly hiding IPs and what not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added notes at the main README file, about how to deploy the production branch of mimic-website.
IP addresses and user names are masked.