Input argument for explicit path comsol installation#249
Closed
teocala wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Hi. Before we look at your solution, let's discuss the issue you want to solve here.
Why not? You can just put that non-standard location on the search path and then Comsol should be found. |
Author
|
Yes, I see the point and I didn't realize it at first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I ran into an issue using the library on a Linux cluster where the COMSOL installation was in a non-standard location. As a result, it couldn't be detected by
discovery.search_disk()anddiscovery.search_path(). I've implemented an optional argument to allow users to provide an explicit installation path.Please note that this is my first PR here, and I have only been able to test these changes on Linux. Thanks for maintaining such a great project! 🙌