Fix test_model.py::test_modules failing with Comsol 6.4#252
Merged
john-hen merged 3 commits intoMay 21, 2026
Conversation
The test `test_modules()` in `test_model.py` was failing with Comsol 6.4, probably because that Comsol version no longer ships with the "Optimization" module that we were querying. I just excluded that from the test.
This seems to be a new addition to Ruff's linter rules that flagged line 408 in `test_model.py`. The test passes regardless, so excluded the rule.
Our custom Sphinx extension `myst_docstring`, which lets us write doc-strings in Markdown instead of reStructuredText, is not compatible with Sphinx 9, for which the Autodoc extension "has been substantially rewritten, and there may be some incompatible changes in edge cases, especially when extensions interact with autodoc internals." See the release notes: https://www.sphinx-doc.org/en/master/changes/9.0.html#release-9-0-0-released-nov-30-2025 That's exactly what our extension does though. The mitigation recommended in the release notes, to set `autodoc_use_legacy_class_based = True` in `conf.py` does not seem to help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
test_modules()intest_model.pywas failing with Comsol 6.4, probably because that Comsol version no longer ships with the "Optimization" module that we were querying. I just excluded that from the test.