Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voxel2mesh fixes #3049

Merged
merged 2 commits into from
Feb 6, 2025
Merged

voxel2mesh fixes #3049

merged 2 commits into from
Feb 6, 2025

Conversation

Lestropie
Copy link
Member

Two minor glitches I found in voxel2mesh when diagnosing issues reported by a colleague.

@Lestropie Lestropie added the bug label Dec 2, 2024
@Lestropie Lestropie added this to the 3.0.5 updates milestone Dec 2, 2024
@Lestropie Lestropie requested a review from a team December 2, 2024 12:29
@Lestropie Lestropie self-assigned this Dec 2, 2024
@Lestropie
Copy link
Member Author

For discoverability: what is rectified in f666c76 is that feeding the result to meshfilter would result in "Cannot perform smoothing on this mesh: no triangulation information" from here. The original voxel2mesh -blocky implementation just generated vertices at voxel corners as required, resulting in duplicate vertices; a later change was supposed to re-use existing vertices so that the resulting surface would be closed, but was not functional.

@Lestropie Lestropie added this pull request to the merge queue Feb 6, 2025
Merged via the queue into master with commit 45d970a Feb 6, 2025
5 checks passed
@Lestropie Lestropie deleted the voxel2mesh_fixes branch February 6, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants