dwi2tensor: fix operation with -iter 1 #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjeurissen
previously approved these changes
Dec 30, 2024
- Previously, if -iter 1 was specified, the weights were not recomputed, and so results were identical to that with -iter 0. - Do not unnecessarily recompute weights at completion of the final iteration.
Lestropie
force-pushed
the
dwi2tensor_iter1_fix
branch
from
7605557 to
be4bdaa
Compare
|
Used GitHub to rebase to updated |
|
Test data contained sample |
daljit46
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem has been present since initial addition of iterative reweighted least squares for tensor fitting in #1542.
Does not affect default operation; only affects the specific use case of
-iter 1.