Add an option 'preserveUndefinedVariables' to keeps undefined variables as is in final output #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es as is in final output
| @@ -375,6 +375,12 @@ Keeps your at-rules like media queries in the order to defined them. | |||
|
|
|||
| Ideally, this would be defaulted to `true` and it will be in the next major version. All of the tests expecations need to be updated and probably just drop support for `preserveAtRulesOrder: false` | |||
|
|
|||
| ### `preserveUndefinedVariables` (default: `false`) | |||
There was a problem hiding this comment.
@vithar Can you give an example of why undefined isn't desired and is conflicting?
Does the existing preserve: true option cover your use case? The undefined value will just fallback to the same preserved value your trying to keep around with this new option.
There was a problem hiding this comment.
If variable is undefined, the build result is width: undefined;.
And, preserve: true will make css file larger
maybe that's why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
postcss-css-variablesgeneratesundefinedin case it process value with undefined variable.In some cases this is undesirable behavior and undefined variables should be leaved as is without modification.
This PR adds an new option
preserveUndefinedVariablesin order to achieve this.