Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Future exception never retrieved in create_connection #590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jensbjorgensen
Copy link
Contributor

@jensbjorgensen jensbjorgensen commented Jan 17, 2024

I also have observed that when I use asyncio.wait_for(...) around loop.create_connection in the timeout case I end up getting this logged to stdout(err?):

Future exception was never retrieved
future: <Future finished exception=gaierror(-2, 'Name or service not known')>
socket.gaierror: [Errno -2] Name or service not known

The code in this commit fixes this.

Copy link
Member

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense! Though a unit test is preferred.

except asyncio.CancelledError as exc:
for fut in fs:
fut.cancel()
raise exc from None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why dropping the original context here, instead of just raise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants