[DOI-1298] New problem property to return UI messages #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blancfabian
force-pushed
the
doi-1298-add-problem-ui-message
branch
from
90baa53 to
b0e8c3d
Compare
| @@ -14,6 +14,7 @@ public abstract class Problem : BaseModel | |||
| public abstract string detail { get; } | |||
| public abstract int status { get; } | |||
| public abstract int errorCode { get; } | |||
| public virtual string message { get; set; } | |||
There was a problem hiding this comment.
I am not sure if adding this property to the base class is a good idea because it does not follow Problem Details for HTTP APIs Standard.
Also, it could be a problem for the localization. In place, The clients could use error and status codes to infer the right message or, if you want a generic non-localizable message you could use detail field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New problem property to return UI messages