Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the deprecated current_request.request_id #80

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Drop the deprecated current_request.request_id #80

merged 1 commit into from
Jan 17, 2025

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 30, 2024 •
edited
Loading

ActiveSupport::Deprecation.warn was removed in activesupport 7.2, and this has been deprecated for a number of releases including 1 major release.

@agrare agrare mentioned this pull request Sep 30, 2024
Closed
jrafanie
jrafanie approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻 😻 😻

@jrafanie
Copy link
Member

@agrare Are we good to merge? Do need to get anything on master into a release before this change?

@agrare
Copy link
Member Author

agrare commented Sep 30, 2024

Since this only actually fails with 7.2 I think we should cut a release with the broadcast logger to support 7.1, then do a major bump with the cloudwatch changes plus this and we can work out any issues on core when we go to bump this.

@jrafanie
Copy link
Member

Since this only actually fails with 7.2 I think we should cut a release with the broadcast logger to support 7.1, then do a major bump with the cloudwatch changes plus this and we can work out any issues on core when we go to bump this.

Looks good, #63 is merged so I think you can cut a release now. Then we can get in #79 and this one.

@jrafanie jrafanie self-assigned this Sep 30, 2024
@agrare agrare force-pushed the remove_deprecated_current_request_request_id_json_logger branch from f87fd37 to 1bdd9a2 Compare September 30, 2024 19:28
@jrafanie
Copy link
Member

@agrare sorry, I loss visibility on this one. Is this ready to go or did we want other changes to go in before the deprecations are in master?

@agrare
Copy link
Member Author

agrare commented Jan 17, 2025

Oh yeah, so #81 is the replacement for #79

I don't have anything else I'd want to get in to a major release right now

@jrafanie jrafanie merged commit 72807e3 into ManageIQ:master Jan 17, 2025
16 checks passed
@agrare agrare deleted the remove_deprecated_current_request_request_id_json_logger branch January 17, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees

@jrafanie jrafanie

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrare @jrafanie @Fryguy