Enhance IBM Power HMC VM reconfigure CPU handling

[dhananjai-yadav]

• support dedicated partition processor count changes
• support shared partition processing unit changes
• add shared partition virtual processor reconfiguration
• validate requested values against LPAR limits

Dependents:

• Add IBM Power HMC-specific CPU reconfiguration support in the classic UI manageiq-ui-classic#10202

[Fryguy]

@dhananjai-yadav Any reason this is draft?

Separately, check your commits author/committer - it's not showing as connected to you (perhaps your commit email is not in your GitHub profile?)

[agrare]

@dhananjai-yadav I don't see any spec tests covering VM reconfigure, can you please add test coverage here?

[dhananjai-yadav]

@dhananjai-yadav Any reason this is draft?

Separately, check your commits author/committer - it's not showing as connected to you (perhaps your commit email is not in your GitHub profile?)

The PR is in draft mode because I'm still making a few final changes.

Good catch 👍🏻 on the commit author/committer.
I'll check my Git configuration and make sure the commit email is associated with my GitHub account.

[agrare]

@dhananjai-yadav it looks like the first commit e39900c still isn't linked to your account, try amending it and force pushing

[agrare]

@dhananjai-yadav in order for this to work from the UI you're going to need changes to ui-classic as well. Unfortunately the VM reconfigure UI isn't pluggable yet.

[dhananjai-yadav]

@dhananjai-yadav it looks like the first commit e39900c still isn't linked to your account, try amending it and force pushing

Thanks, for pointing it, did the fix

[dhananjai-yadav]

@dhananjai-yadav in order for this to work from the UI you're going to need changes to ui-classic as well. Unfortunately the VM reconfigure UI isn't pluggable yet.

yes, i already created a PR there as well : ManageIQ/manageiq-ui-classic#10202

[miq-bot]

Checked commits dhananjai-yadav/manageiq-providers-ibm_power_hmc@575be7c~...033611e with ruby 3.3.10, rubocop 1.86.0, haml-lint 0.73.0, and yamllint 1.37.1
4 files checked, 0 offenses detected
Everything looks fine. 🍰

[Fryguy]

@agrare Do we want to wait for the subclassed reconfigure or get this in first, then modify it later when core is updated?

[agrare]

Do we want to wait for the subclassed reconfigure or get this in first, then modify it later when core is updated?

The changes here ManageIQ/manageiq-ui-classic#10202 (comment) look fine enough, but these ManageIQ/manageiq-ui-classic#10202 (comment) are way too provider specific. If there isn't a more general way of doing that we will have to wait until we can load DDF forms from provider subclasses.