Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Commit

Permalink
Fix "<select> per page" styling in patternfly 3.25
Browse files Browse the repository at this point in the history
The css comes from patternfly/patternfly#910, wrapped in a `.miq-v2v` so that we can be sure this only affects v2v screeens.

Unfortunately dialogs get opened directly under body, so any such class needs to live on body.

(Fortunately there are no cross-controller ajax transitions in gaprindashvili.)
  • Loading branch information
himdel authored and AparnaKarve committed Jun 19, 2018
1 parent 33b0c42 commit ba6acfa
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
13 changes: 13 additions & 0 deletions app/javascript/react/screens/App/Overview/Overview.scss
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,19 @@ hr {
margin-left: initial;
}

// Patternfly 3.25 compatibility - comes from patternfly/patternfly#910, made specific to v2v for gaprindashvili
.miq-v2v .content-view-pf-pagination .form-group {
.pagination-pf-pagesize.bootstrap-select.btn-group,
.pagination-pf-pagesize.btn-group {
display: flex;
float: none;
margin-bottom: 0;
margin-left: 0;
margin-right: 5px;
width: auto;
}
}

// The below style could be moved to core for the ConfirmModal component (or first, to the CSS in patternfly-react for that)

.confirm-warning-icon {
Expand Down
4 changes: 4 additions & 0 deletions app/views/layouts/_full_center_v2v.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@

.container-fluid.container-pf-nav-pf-vertical.container-pf-nav-pf-vertical-with-sub-menus{:style => "overflow: hidden; height: 100%;"}
= yield

:javascript
// gaprindashvili-specific hack to support v2v-specific styling even for dialogs (outside #reactRoot)
$('body').addClass('miq-v2v');

0 comments on commit ba6acfa

Please sign in to comment.