Skip to content

Conversation

@M0nkeySan
Copy link
Collaborator

What

When a release has a changelog too big or a note is too big, homer can fail to send the message to slack due to the character limitation.

The current slackifyChangelog method is duplicated and can fail.
I created a new one slackifyText to remove the duplication, allow to specify the truncatedMessage and customize the maximum character allowed.

Also, I didn't change ReleaseOptions to avoid breaking change.

ThibautManoMano and others added 3 commits September 4, 2025 15:58
…ifyText` for improved handling and add truncation helper.

Also use it to truncate the notes.

Didn't change `ReleaseOptions` to avoid breaking change.
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.94%. Comparing base (5af23ae) to head (5709b37).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/changelog/buildChangelogModalView.ts 50.00% 1 Missing ⚠️
...release/commands/create/utils/slackifyChangelog.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   78.63%   78.94%   +0.30%     
==========================================
  Files          95       95              
  Lines        1947     1947              
  Branches      343      348       +5     
==========================================
+ Hits         1531     1537       +6     
+ Misses        407      383      -24     
- Partials        9       27      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@M0nkeySan M0nkeySan requested a review from pfongkye September 4, 2025 14:26
@M0nkeySan M0nkeySan requested review from cicoub13 and removed request for pfongkye September 25, 2025 12:52
Copy link
Member

@cicoub13 cicoub13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

@M0nkeySan M0nkeySan merged commit de2f569 into main Sep 25, 2025
3 checks passed
@M0nkeySan M0nkeySan deleted the fix/slackifyChangelog branch October 31, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants