Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually correct subsource status from starting to running #31096

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sjwiesman
Copy link
Contributor

Subsources move from starting to running lazily once they see a record flow through, even though they are online and healthy. This has been repeatedly brought up as confusing by users. So now, if the parent source is running, and the subsource is starting, we override its status to running to relfect its healthy status.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@sjwiesman sjwiesman requested a review from a team as a code owner January 17, 2025 19:21
@sjwiesman sjwiesman requested a review from aljoscha January 17, 2025 19:21
Subsources move from starting to running lazily once they see
a record flow through, even though they are online and healthy.
This has been repeatedly brought up as confusing by users.
So now, if the parent source is running, and the subsource is
starting, we override its status to running to relfect its healthy
status.
@sjwiesman sjwiesman force-pushed the subsource-reporting branch from d5b8e5e to 22729a1 Compare January 17, 2025 19:55
@morsapaes morsapaes requested a review from a team January 17, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant