Skip to content

jemalloc: use GCC intrinsics for unwinding in profiling #32141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Apr 9, 2025

This is a workaround for deadlocks caused by nested unwinding. Alternative to #32139.

Motivation

  • This PR fixes a recognized bug.

Fixes https://github.com/MaterializeInc/database-issues/issues/9159

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

def- and others added 2 commits April 9, 2025 14:37
@def-
Copy link
Contributor

def- commented Apr 9, 2025

We can do a bunch of anyhow! calls to have a quick stress test to see if this prevents the issues. (or revert #32138)

@teskje
Copy link
Contributor Author

teskje commented Apr 9, 2025

I assume all the segfaults in CI come from us not enforcing frame pointers. We could enforce them with force-frame-pointers, but we'd also have to do so for all libraries we depend on and apparently we risk segfaults if we miss one. The libunwind approach feels safer, if we can get it to work.

@teskje teskje force-pushed the jemalloc-gcc-intrinsics branch from 8bf040a to 8668ef6 Compare April 14, 2025 13:48
@teskje teskje force-pushed the jemalloc-gcc-intrinsics branch from 8668ef6 to 6af9155 Compare April 14, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants