allow orchestratord to force a rollout to promote before it's ready #32177
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows us to choose how to resolve a rollout which is stuck or taking too long - we can either cancel the rollout (by resetting the reconciliation_id to the last reconciliation id from the status) or now force it to complete by setting force_promote to the reconciliation_id value.
doy-materialize
force-pushed
the
push-xspomtxvstww
branch
from
1344b17 to
0dfb70a
Compare
| // generation to rehydrate before promoting the new environmentd to | ||
| // leader. | ||
| #[serde(default)] | ||
| pub force_promote: Uuid, |
There was a problem hiding this comment.
Does this need to be an Option<Uuid> to handle already existing CRs? What does K8S do in cases where a new CRD definition is incompatible with the old stored data?
The #[serde(default)] handles missing data on the controller side, but does K8S even allow you to upgrade the CRD in this way?
There was a problem hiding this comment.
as far as i can tell from testing, this works as you would want it to
alex-hunt-materialize
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
this allows us to choose how to resolve a rollout which is stuck or taking too long - we can either cancel the rollout (by resetting the reconciliation_id to the last reconciliation id from the status) or now force it to complete by setting force_promote to the reconciliation_id value.
Tips for reviewer
not planning on porting this to the environment controller since it we're so close to getting rid of it
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.