Skip to content

Remove DownValues hack for Mathics/WMA return value compatibility. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove DownValues hack for Mathics/WMA return value compatibility. #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dcb2e13
Remove DownValues hack for Mathics/WMA return value compatibility.
aravindh-krishnamoorthy Aug 14, 2025
548ab41
Fixes to get TestRubi["SanityCheck.m"] started.
aravindh-krishnamoorthy Nov 1, 2025
ad5d44f
Dummy CheckArguments function
aravindh-krishnamoorthy Nov 1, 2025
02a8d9f
Fix CheckArguments attributes.
aravindh-krishnamoorthy Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions IntegrationUtilityFunctions.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4103,13 +4103,13 @@

DownValues[Star]={};


(*
Star::error = "Inert multiplication by zero!";
Star[u_,v_] := (
Message[Star::error];
0 ) /;
EqQ[u,0]

*)

Star[u_,v_] :=
Map[Function[Star[u,#]],v] /;
Expand Down Expand Up @@ -7734,11 +7734,8 @@ If u is an expression of the form f (Sqrt[a+b*x+c*x^2],x), f (x,x) is a rational

ClearAll[FixIntRules,FixIntRule,FixRhsIntRule]

dvMathicsToMath = RuleDelayed[Verbatim[HoldPattern][Verbatim[Condition][lhs_,cond_]],rhs_] :> RuleDelayed[HoldPattern[lhs],Condition[rhs,cond]];
dvMathToMathics = RuleDelayed[Verbatim[HoldPattern][lhs_], Verbatim[Condition][rhs_,cond_]] :> RuleDelayed[HoldPattern[Condition[lhs,cond]],rhs];

FixIntRules[] :=
(DownValues[Int]=FixIntRules[DownValues[Int] /. dvMathicsToMath] /. dvMathToMathics; Null)
(DownValues[Int]=FixIntRules[DownValues[Int]]; Null)


FixIntRules[rulelist_] := Block[{Int, Subst, Simp, Star},
Expand Down
5 changes: 5 additions & 0 deletions Rubi.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,11 @@
TraceBuiltins[DownValues[Int] = DownValues[Int] /. dvFixWith /. dvFixWithNoCond, SortBy->"count"];
Print[""];

(* Dummy CheckArguments *)
CheckArguments[a_, n_] := n == 1;
CheckArguments[f_[args___], n_] := Length[{args}] == n;
SetAttributes[CheckArguments, HoldFirst];

If[$LoadShowSteps === True,
StatusBarPrint["Modifying " <> ToString[$RuleCount] <> " integration rules to display steps..."];
StepFunction[Int];
Expand Down
2 changes: 1 addition & 1 deletion Test.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
(* ::Section::Closed:: *)
(*Mathematica Test Functions*)

If[Not[ValueQ[$ItegrationTestProgramDir], $IntegrationTestProgramDir = Directory[]]];
If[Not[ValueQ[$ItegrationTestProgramDir]], $IntegrationTestProgramDir = Directory[]];

Begin["`Private`"];

Expand Down