Fix arithmetic format #892
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework arithmetic format
mmatera
commented
Jul 29, 2023
| . | ||
| . Format[Dice[n_Integer ? (1 <= #1 <= 6&)], OutputForm] = Block[{p = 0.2, r = 0.05}, Graphics[{EdgeForm[Black], White, Rectangle[], Black, EdgeForm[], If[OddQ[n], Disk[{0.5, 0.5}, r]], If[MemberQ[{2, 3, 4, 5, 6}, n], Disk[{p, p}, r]], If[MemberQ[{2, 3, 4, 5, 6}, n], Disk[{Plus[1, Times[-1, p]], Plus[1, Times[-1, p]]}, r]], If[MemberQ[{4, 5, 6}, n], Disk[{p, Plus[1, Times[-1, p]]}, r]], If[MemberQ[{4, 5, 6}, n], Disk[{Plus[1, Times[-1, p]], p}, r]], If[n === 6, {Disk[{p, 0.5}, r], Disk[{Plus[1, Times[-1, p]], 0.5}, r]}]}, ImageSize -> Tiny]] |
There was a problem hiding this comment.
This is not perfect, but at least I got something less weird than what we have in master.
rocky
reviewed
Jul 30, 2023
| # Force parenthesis by adjusting the surrounding context's precedence value, | ||
| # We can't change the precedence for the number since it, doesn't | ||
| # have a precedence value. | ||
| element_prec = 480 |
There was a problem hiding this comment.
I am pretty sure this is not the right way to fix this. There is always a precedence for all atoms.
|
You were going to come up with a proof of concept by writing MakeBox in Mathics3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step to improving the way in which arithmetic expressions are formatted. I started trying to fix how
DirectedInfinityexpressions are formatted, using the standard syntax of WL. However, on each attempt to do that, I collide against the flawed design of our formatting system.At this point, this is getting large, and still there is a lot of work to do. However, with these changes many expressions are formatted in a closer way than in WMA, and I did some steps in order to disentangle the code.
I will leave this here as a draft for a while.