Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send messages to destroyed webContents #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't send messages to destroyed webContents #11

wants to merge 2 commits into from

Commits on Jan 31, 2018

  1. Don't send messages to destroyed webContents 

    This commit:
1. Prevents sending messages to destroyed webContents (which result in a crash)
2. Allows registering multiple webContents for push notifications

We need this because we are listening for notifcations in a specific
webContents. If it crashes we create a new one and call setup again,
without this change the next push notification that came in would cause
a crash.
    @ibash
    ibash committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    1e3a540 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. Remove calls to isDestroyed 

    That seems to be crashing the app ref: electron/electron#11797
    @ibash
    ibash committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    dbfa9e8 View commit details
    Browse the repository at this point in the history