Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tf-psa-crypto] Remove DHM module #175

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions docs/driver-only-builds.md
Original file line number Diff line number Diff line change
Expand Up @@ -246,14 +246,14 @@ Key management and usage can be enabled by means of the usual `PSA_WANT` +

The same holds for the associated algorithm:
`[PSA_WANT|MBEDTLS_PSA_ACCEL]_ALG_FFDH` allow builds accelerating FFDH and
removing builtin support (i.e. `MBEDTLS_DHM_C`).

Note that the PSA API only supports FFDH with RFC 7919 groups, whereas the
Mbed TLS legacy API supports custom groups. As a consequence, the TLS 1.2
layer of Mbed TLS only supports DHE cipher suites if built-in FFDH
(`MBEDTLS_DHM_C`) is present, even when `MBEDTLS_USE_PSA_CRYPTO` is enabled.
(The TLS 1.3 layer uses PSA, and this is not a limitation because the
protocol does not allow custom FFDH groups.)
removing builtin support.

Note that the PSA API only supports FFDH with RFC 7919 groups.
In theory TLS 1.2 allows custom FFDH groups to be used in DHE key exchanges, but
since DHE-RSA and DHE-PSK key exchanges support has been removed from Mbed TLS,
PSA API limitation to RFC 7919 groups is not a problem.
TLS 1.3 is also fine because the protocol itself does not allows custom FFDH
groups.

RSA
---
Expand Down
1 change: 0 additions & 1 deletion drivers/builtin/include/mbedtls/error_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
* PKCS#12 1 4 (Started from top)
* X509 2 20
* PKCS5 2 4 (Started from top)
* DHM 3 11
* PK 3 15 (Started from top)
* RSA 4 11
* ECP 4 10 (Started from top)
Expand Down
Loading