[framework] Remove DHM module #138
Conversation
valeriosetti
added
needs-review
Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
force-pushed
the
issue9956-framework
branch
from
681b88b to
b451a7e
Compare
| @@ -20,7 +20,7 @@ | |||
| from generate_test_code import parse_function_arguments, parse_function_code | |||
| from generate_test_code import parse_functions, END_HEADER_REGEX | |||
| from generate_test_code import END_SUITE_HELPERS_REGEX, escaped_split | |||
| from generate_test_code import parse_test_data, gen_dep_check | |||
| from generate_test_code import gen_dep_check | |||
There was a problem hiding this comment.
Is this import supposeed to be here?
There was a problem hiding this comment.
Please don't remove the unit tests for parse_test_data. The fact that they happen to mention DHM is not really important, this code isn't technically related to the DHM module.
We could rewrite the unit tests to use function names that still exist in TF-PSA-Crypto, but it's unimportant. We can leave test_generate_test_code.py alone.
| """ | ||
| data = """ | ||
| Diffie-Hellman full exchange #1 | ||
| dhm_do_dhm:10:"23":10:"5" |
There was a problem hiding this comment.
These are unit tests for the test code generator. They only compare the source .data file with the Python data obtained after parsing. It doesn't matter whether the first field of the second line is an existing function in Mbed TLS.
I guess it would be marginally better to have some actual code from a .data file as a unit test here, but it doesn't really matter. We can keep what's there.
We do, however, need to keep having unit tests for parse_test_data.
|
Closing as the only change requested in the |
Description
Helps resolving Mbed-TLS/mbedtls#9956.
PR checklist