[development] Remove DHM module #9972
Conversation
These sample programs depend on MBEDTLS_DHM_C which is being removed, so they should be as well. Signed-off-by: Valerio Setti <[email protected]>
MBEDTLS_DHM_C is being removed so all its occurencies should be removed as well. Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
The file is being removed together with the removal of MBEDTLS_DHM_C. Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
The file was cancelled from the tf-psa-crypto repo following the removal of MBEDTLS_DHM_C. Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
added
needs-review
valeriosetti
force-pushed
the
issue9956-development
branch
from
76a10d3 to
931125a
Compare
|
I checked ABI-API failures and they look reasonable to me for this kind of PR. |
Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
force-pushed
the
issue9956-development
branch
from
931125a to
58a0085
Compare
| @@ -42,7 +42,6 @@ int main(void) | |||
| #include "mbedtls/hmac_drbg.h" | |||
There was a problem hiding this comment.
We have been through some difficulties to move new files from Mbed TLS to TF-PSA-Crypto (see Mbed-TLS/TF-PSA-Crypto#164). It would be all together easier to move benchmark.c to TF-PSA-Crypto before we start modifying it. We have not changed it since the commit that was used for the split. The identifier of this commit is 8ef9323. Thus in TF-PSA-Crypto, we just have to do "git checkout 8ef9323 -- programs/test/benchmark.c" to get into TF-PSA-Crypto benchmark.c in its current version and with all of its git history. And we have an issue for the move of benchmark.c to TF-PSA-Crypto: #9971. Thus could you address #9971 as a prerequisite to the removal of the DHM module?
There was a problem hiding this comment.
Thus in TF-PSA-Crypto, we just have to do "git checkout 8ef9323 -- programs/test/benchmark.c" to get into TF-PSA-Crypto benchmark.c in its current version and with all of its git history.
I just tried the command: it creates the file as expected, but git log just shows the last commit (the one that I would do when adding this file), not the entire history. Am I missing something?
There was a problem hiding this comment.
git log --follow programs/test/benchmark.c tracks the file through delete/recreate.
Description
Resolves #9956
This PR depends on:
Once that will be merged, then the merge sequence for this PR will be:
PR checklist