Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum JDK 17 required #5

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Minimum JDK 17 required #5

wants to merge 13 commits into from

Conversation

Longwater1234
Copy link
Contributor

  • update to JUnit 5
  • minimum requirement is JDK 17
  • add "Help" > "About" menu in toolbar
  • some minor code cleanup
  • add screenshot inside README.md from resources foler

@Longwater1234
Copy link
Contributor Author

@Mchristos Please review this pull request

@Mchristos
Copy link
Owner

@Mchristos Please review this pull request

@Longwater1234 thanks for the PR! I noticed the folder structure includes java/org/davistiba is that needed, seems that name is personal to you?

I haven't used Java in ages so I know very little about the ecosystem / tooling etc.

@Longwater1234
Copy link
Contributor Author

Longwater1234 commented Mar 12, 2025 •
edited
Loading

Oh yes, you are correct. Wait, I will rename it to your name, mchristos, and commit. @Mchristos

@Mchristos Mchristos self-requested a review March 12, 2025 15:04
@Longwater1234
Copy link
Contributor Author

@Mchristos Done migrated to your name. You can preview if you can run it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mchristos Mchristos Awaiting requested review from Mchristos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Longwater1234 @Mchristos