Skip to content

Added swiping for multi-photo posts - #624

Open
joshua-davis-rose wants to merge 6 commits into
Memmy-App:mainfrom
joshua-davis-rose:feature/multi-image-swiping
Open

Added swiping for multi-photo posts#624
joshua-davis-rose wants to merge 6 commits into
Memmy-App:mainfrom
joshua-davis-rose:feature/multi-image-swiping

Conversation

@joshua-davis-rose

@joshua-davis-rose joshua-davis-rose commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

I noticed posts with more than two photos couldn't load the additional photos. This will allow swiping of photos when viewing full-size.

swipe

@joshua-davis-rose

Copy link
Copy Markdown
Contributor Author

The animated gif in the description isn't playing nice. Clicking on it will let you see the animation though.

@gkasdorf

Copy link
Copy Markdown
Collaborator

This almost works but there's a few things I need to fix in the image library to make it work. Biggest issue is when swiping between images it doesn't want to adjust the scale. I'll work on this tomorrow and should be good to merge after that.

@joshua-davis-rose

Copy link
Copy Markdown
Contributor Author

It looks like I might have a couple linting issues I need to take care of too. I'll clean that up.

@joshua-davis-rose

Copy link
Copy Markdown
Contributor Author

I found a bug. Hold off on merging.

@joshua-davis-rose

Copy link
Copy Markdown
Contributor Author

Should be good now

@gkasdorf

Copy link
Copy Markdown
Collaborator

Cool. I'm about to work on that image viewer as we speak, so I should have this merged in within a few hours.

@joshua-davis-rose

Copy link
Copy Markdown
Contributor Author

Given your changes yesterday it looks pretty unlikely this is going to be implemented as-is. Should I close this and we can talk about how to make it work with the new ImageViewer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants