Enhance embedding configuration and error handling #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
devwdave
commented
Dec 21, 2025
devwdave
commented
- Added an Embeddings class to encapsulate model and fallback dimension settings in the configuration.
- Updated embedding functions to utilize the new configuration, ensuring consistent model usage and fallback handling.
- Improved error handling in embedding functions to manage dimension mismatches and encoding failures gracefully.
- Updated tests to reflect changes in embedding function signatures and configurations, ensuring robust coverage for various scenarios.
- Introduced new benchmarks for embedding performance across different query lengths and batch sizes.
- Added an Embeddings class to encapsulate model and fallback dimension settings in the configuration. - Updated embedding functions to utilize the new configuration, ensuring consistent model usage and fallback handling. - Improved error handling in embedding functions to manage dimension mismatches and encoding failures gracefully. - Updated tests to reflect changes in embedding function signatures and configurations, ensuring robust coverage for various scenarios. - Introduced new benchmarks for embedding performance across different query lengths and batch sizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.