Skip to content

merge queue: checking #122 on main (41d7cdf) - #133

Closed
mergify[bot] wants to merge 2 commits into
mainfrom
mergify/merge-queue/5da0c8e19a
Closed

merge queue: checking #122 on main (41d7cdf)#133
mergify[bot] wants to merge 2 commits into
mainfrom
mergify/merge-queue/5da0c8e19a

Conversation

@mergify

@mergify mergify Bot commented Aug 31, 2026

Copy link
Copy Markdown

🎉 This pull request has been checked successfully and will be merged soon. 🎉

#122 is queued for merge on branch main (41d7cdf).

This pull request has been created by Mergify to check the mergeability of #122.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue rule default for merge:

Required conditions to stay in the queue:

---
checking_base_sha: 41d7cdff9b3c1d71495f1c68ae1df0f6998aed76
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 122
    scopes: []
scopes: []
...

AlexandreGaubert and others added 2 commits August 28, 2026 10:07
The engine is gaining a third answer on the test-selection endpoint --
`selection: "empty"`, meaning "run no test, the predecessor already ran
them and they passed" (Mergifyio/monorepo#39373). Every published client
predates it, and each degrades correctly today only by accident of three
unpinned facts: the decoder types `selection` as a free `String`,
`test_selection_dict` always sets the `tests` key, and
`TestSelection.__post_init__` normalises anything that is not a non-empty
`subset` back to a full run. Tighten `selection` into a closed enum for
hygiene -- the obvious next edit -- and every already-shipped client stops
decoding any answer the server invents.

Pin the two ends of that property: decoding an `empty` payload in
mergify-ci-api, and normalising an unrecognised selection to "run
everything" rather than "run nothing" in the plugin. Both were verified to
fail under the edit they guard against. The marshalling comment claiming a
missing `tests` means a `full` answer is corrected -- it holds for any
answer carrying no subset.

pytest only: vitest and playwright share the decoder but normalise in
their own TypeScript, and the pilot does not enable them.

Related to MRGFY-8931

Change-Id: Ifccfcfb1a7a205b6985329744da4aed644b61ddb
@mergify
mergify Bot deployed to Mergify Merge Protections August 31, 2026 12:35 Active
@mergify mergify Bot closed this Aug 31, 2026
@mergify
mergify Bot deleted the mergify/merge-queue/5da0c8e19a branch August 31, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant