merge queue: checking #122 on main (41d7cdf) - #133
Closed
mergify[bot] wants to merge 2 commits into
Closed
Conversation
The engine is gaining a third answer on the test-selection endpoint -- `selection: "empty"`, meaning "run no test, the predecessor already ran them and they passed" (Mergifyio/monorepo#39373). Every published client predates it, and each degrades correctly today only by accident of three unpinned facts: the decoder types `selection` as a free `String`, `test_selection_dict` always sets the `tests` key, and `TestSelection.__post_init__` normalises anything that is not a non-empty `subset` back to a full run. Tighten `selection` into a closed enum for hygiene -- the obvious next edit -- and every already-shipped client stops decoding any answer the server invents. Pin the two ends of that property: decoding an `empty` payload in mergify-ci-api, and normalising an unrecognised selection to "run everything" rather than "run nothing" in the plugin. Both were verified to fail under the edit they guard against. The marshalling comment claiming a missing `tests` means a `full` answer is corrected -- it holds for any answer carrying no subset. pytest only: vitest and playwright share the decoder but normalise in their own TypeScript, and the pilot does not enable them. Related to MRGFY-8931 Change-Id: Ifccfcfb1a7a205b6985329744da4aed644b61ddb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#122 is queued for merge on branch main (41d7cdf).
This pull request has been created by Mergify to check the mergeability of #122.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by>=2author = dependabot[bot]author = mergify-ci-botauthor = renovate[bot]📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success=ci-gateRequired conditions to stay in the queue:
base=mainlabel!=manual mergeEnforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by>=2author = dependabot[bot]author = mergify-ci-botauthor = renovate[bot]📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success=ci-gate