chore: align ethereumjs versions #5347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danroc
reviewed
Feb 17, 2025
| @@ -3899,7 +3897,7 @@ describe('KeyringController', () => { | |||
| } | |||
| }); | |||
| // TODO: Either fix this lint violation or explain why it's necessary to ignore. | |||
There was a problem hiding this comment.
The TODO no longer seems relevant since the line bellow was removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Align
@ethereumjs/*package versions to avoid any risk of incompatibility and simplify future maintenance.Upgrade originally required by
@metamask/transaction-controllerto support EIP-7702 transactions.References
@metamask/utilsPR@metamask/accountsPRChangelog
See changelogs.
Checklist