Chore/poll timeout duration #5683
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infiniteflower
requested changes
Apr 21, 2025
| } from './utils/transaction'; | ||
| import { generateActionId } from './utils/transaction'; | ||
| import { getKey } from '../../polling-controller/src/AbstractPollingController'; |
There was a problem hiding this comment.
Import this using @metamask/polling-controller rather than a relative import.
| @@ -30,8 +30,18 @@ function StaticIntervalPollingControllerMixin< | |||
| { | |||
| readonly #intervalIds: Record<PollingTokenSetId, NodeJS.Timeout> = {}; | |||
|
|
|||
| #durationIds: Record<PollingTokenSetId, number> = {}; | |||
There was a problem hiding this comment.
Can we add a comment on what this is?
Also I think maybe the name can be more clear. Calling it durationIds reads to me like the value of this key-value pair is an id, but it's really the duration and the key is id.
Maybe durationsById
| #intervalLength: number | undefined = 1000; | ||
|
|
||
| setKeyDuration(key: string, duration: number) { |
There was a problem hiding this comment.
Suggested change
| setKeyDuration(key: string, duration: number) { | |
| setDurationForId(id: string, duration: number) { |
Just to keep in line with the id terminology of PollingTokenSetId.
| this.#durationIds[key] = duration; | ||
| } | ||
|
|
||
| getKeyDuration(key: string) { |
There was a problem hiding this comment.
Suggested change
| getKeyDuration(key: string) { | |
| getDurationForId(id: string) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Added a time limit of 5 minutes to the bridge status controller
References
Changelog
Bridge status controller
Polling static intervals controller
Checklist