chore: reduce tokenBalances state updates #5726
Open
+568
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
sahar-fehri
force-pushed
the
fix/reduce-token-balances-updates
branch
from
af73133 to
aa59638
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
7 tasks
sahar-fehri
commented
May 1, 2025
| this.update((state) => { | ||
| // Reset so that when accounts or tokens are removed, | ||
| // their balances are removed rather than left stale. | ||
| for (const accountAddress of Object.keys(state.tokenBalances)) { |
There was a problem hiding this comment.
Instead of resetting account balances here; we will explicitly handle the case when an account is removed and when a token is removed
sahar-fehri
commented
May 1, 2025
| const { accountAddress, tokenAddress } = accountTokenPairs[i]; | ||
| // if all values of isTokenBalanceValueChanged are false, return | ||
| if (updatedResults.every((result) => !result.isTokenBalanceValueChanged)) { | ||
| return; |
There was a problem hiding this comment.
If none of the balances has changed, return and dnt update state
Prithpal-Sooriya
approved these changes
May 1, 2025
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
When a user removes an account; tokenBalances controller would still fetch balances for the tokens and update state.
This was happening because tokensController does not remove tokens from state when a user removes the account.
This PR cleans up tokens from tokensController state once a user removes an account.
It also cleans up the balances from state when the user removes the account.
This PR also adds a check to see if token balances has changed after fetching them; if none of the balances changed; no need to update state.
References
Changelog
Checklist