Skip to content

fix: include gas in simulation requests #5754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented May 2, 2025

Explanation

Include gas limit and gas fees in balance change simulation requests.

Specifically:

  • Create alternate simulation request specifically for gas fee tokens in new utils/gas-fee-tokens.ts.
  • Rename utils/simulation.ts to utils/balance-changes.ts.
  • Add withGas and withDefaultBlockOverrides to balance change simulation requests.
  • Override balance in balance change requests if insufficient balance.
  • Replace code override with authorizationList with from property.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0 matthewwalsh0 force-pushed the fix/simulation-include-gas branch from e5a0379 to 9126697 Compare May 5, 2025 15:50
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review May 5, 2025 16:09
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners May 5, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant