fix(action): add several checks to make sure we find the release branch or we are informed if we don't #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch or we are informed if we don't
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @@ -223,7 +248,7 @@ async function main() { | |||
| `Generating CSV file for commits between ${branchA} and ${branchB} on ${platform} platform...`, | |||
| ); | |||
|
|
|||
| const commitsByTeam = await filterCommitsByTeam(platform, branchA, branchB); | |||
| const commitsByTeam = await filterCommitsByTeam(platform, `origin/${branchA}`, `origin/${branchB}`); | |||
There was a problem hiding this comment.
Bug: Branch Validation Mismatch
The branch existence validation checks for local branches (branchA, branchB), but the filterCommitsByTeam function subsequently uses remote branches (origin/${branchA}, origin/${branchB}). This inconsistency means the script might pass validation when local branches exist but fail during the git log operation if the corresponding remote branches are missing, or vice versa. The validation should check the same remote references that are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.