Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing circular dependencies from avatar favicon #448

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Feb 20, 2025

Description

This PR continues the work to remove circular dependencies by addressing the re-export of AvatarBaseSize as AvatarFaviconSize. Instead of re-exporting AvatarBaseSize, we now define a dedicated AvatarFaviconSize enum in the AvatarFavicon.types.ts file. This change:

  1. Removes the circular dependency between AvatarFavicon and AvatarBase
  2. Makes the AvatarFavicon component more self-contained
  3. Improves maintainability by explicitly defining size values for AvatarFavicon

This is part of a larger effort to clean up circular dependencies in the design system.

Related issues

Partially fixes: #445

Manual testing steps

  1. Run storybook and verify all AvatarFavicon stories render correctly
  2. Run tests and ensure all tests pass
  3. Check build process completes successfully

Screenshots/Recordings

Before

N/A (No visual changes)

After

N/A (No visual changes)

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall force-pushed the fix/avatar-favicon-circular-deps branch from e71d747 to fbd1fe9 Compare February 20, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Remove circular dependencies and fix type exports
1 participant