fix: removing circular dependencies from avatar favicon #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR continues the work to remove circular dependencies by addressing the re-export of
AvatarBaseSize
asAvatarFaviconSize
. Instead of re-exportingAvatarBaseSize
, we now define a dedicatedAvatarFaviconSize
enum in theAvatarFavicon.types.ts
file. This change:AvatarFavicon
andAvatarBase
AvatarFavicon
component more self-containedAvatarFavicon
This is part of a larger effort to clean up circular dependencies in the design system.
Related issues
Partially fixes: #445
Manual testing steps
AvatarFavicon
stories render correctlyScreenshots/Recordings
Before
N/A (No visual changes)
After
N/A (No visual changes)
Pre-merge author checklist
Pre-merge reviewer checklist