Skip to content

Commit

Permalink
chore: bump ethereumjs (#30716)
Browse files Browse the repository at this point in the history
## **Description**

Upgrade all `@ethereumjs/*` packages including the keyrings and
`KeyringController` since they depend on `ethereumjs` packages
internally.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30716?quickstart=1)

## **Related issues**

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Michele Esposito <[email protected]>
Co-authored-by: MetaMask Bot <[email protected]>
Co-authored-by: Michele Esposito <[email protected]>
  • Loading branch information
4 people authored Mar 7, 2025
1 parent da1c33e commit 32c9974
Show file tree
Hide file tree
Showing 11 changed files with 1,312 additions and 380 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ function buildControllerMock(

function buildInitRequestMock(): jest.Mocked<
ControllerInitRequest<
// @ts-expect-error TODO: Resolve mismatch between base-controller versions.
TransactionControllerMessenger,
TransactionControllerInitMessenger
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import { TransactionMetricsRequest } from '../../../../shared/types/metametrics'

export const TransactionControllerInit: ControllerInitFunction<
TransactionController,
// @ts-expect-error TODO: Resolve mismatch between base-controller versions.
TransactionControllerMessenger,
TransactionControllerInitMessenger
> = (request) => {
Expand Down Expand Up @@ -189,7 +188,6 @@ function getApi(

function getControllers(
request: ControllerInitRequest<
// @ts-expect-error TODO: Resolve mismatch between base-controller versions.
TransactionControllerMessenger,
TransactionControllerInitMessenger
>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ export type TransactionControllerInitMessenger = ReturnType<
export function getTransactionControllerMessenger(
messenger: Messenger<MessengerActions, MessengerEvents>,
): TransactionControllerMessenger {
// @ts-expect-error TODO: Resolve mismatch between base-controller versions.
return messenger.getRestricted({
name: 'TransactionController',
allowedActions: [
Expand Down
Loading

0 comments on commit 32c9974

Please sign in to comment.