updated permissions connect to use cached origin and target subject m…

…etadata
MetaMask · Jan 24, 2025 · 66b1fcd · 66b1fcd
1 parent 17928df
commit 66b1fcd
Showing 1 changed file with 21 additions and 9 deletions.
diff --git a/ui/pages/permissions-connect/permissions-connect.component.js b/ui/pages/permissions-connect/permissions-connect.component.js
@@ -131,6 +131,9 @@ export default class PermissionConnect extends Component {
       this.props.permissionsRequest,
     ),
     permissionsApproved: null,
+    origin: this.props.origin,
+    targetSubjectMetadata: this.props.targetSubjectMetadata || {},
+    snapsInstallPrivacyWarningShown: this.props.snapsInstallPrivacyWarningShown,
   };
 
   componentDidMount() {
@@ -153,7 +156,14 @@ export default class PermissionConnect extends Component {
       history.replace(DEFAULT_ROUTE);
       return;
     }
-
+    // if this is an incremental permission request for permitted chains, skip the account selection
+    if (
+      permissionsRequest?.diff?.permissionDiffMap?.[
+        PermissionNames.permittedChains
+      ]
+    ) {
+      history.replace(confirmPermissionPath);
+    }
     if (history.location.pathname === connectPath && !isRequestingAccounts) {
       switch (requestType) {
         case 'wallet_installSnap':
@@ -175,8 +185,8 @@ export default class PermissionConnect extends Component {
   }
 
   componentDidUpdate(prevProps) {
-    const { permissionsRequest, lastConnectedInfo, origin } = this.props;
-    const { redirecting } = this.state;
+    const { permissionsRequest, lastConnectedInfo } = this.props;
+    const { redirecting, origin } = this.state;
 
     if (!permissionsRequest && prevProps.permissionsRequest && !redirecting) {
       const accountsLastApprovedTime =
@@ -262,7 +272,7 @@ export default class PermissionConnect extends Component {
   }
 
   renderTopBar(permissionsRequestId) {
-    const { targetSubjectMetadata } = this.props;
+    const { targetSubjectMetadata } = this.state;
     const handleCancelFromHeader = () => {
       this.cancelPermissionsRequest(permissionsRequestId);
     };
@@ -319,12 +329,14 @@ export default class PermissionConnect extends Component {
       rejectPendingApproval,
       setSnapsInstallPrivacyWarningShownStatus,
       approvePermissionsRequest,
-      snapsInstallPrivacyWarningShown,
-      origin,
       history,
     } = this.props;
-    const { selectedAccountAddresses, permissionsApproved, redirecting } =
-      this.state;
+    const {
+      selectedAccountAddresses,
+      permissionsApproved,
+      redirecting,
+      snapsInstallPrivacyWarningShown,
+    } = this.state;
 
     const isRequestingSnap = isSnapId(permissionsRequest?.metadata?.origin);
 
@@ -366,7 +378,7 @@ export default class PermissionConnect extends Component {
                     rejectPermissionsRequest={(requestId) =>
                       this.cancelPermissionsRequest(requestId)
                     }
-                    activeTabOrigin={origin}
+                    activeTabOrigin={this.state.origin}
                     request={permissionsRequest}
                     permissionsRequestId={permissionsRequestId}
                     approveConnection={this.approveConnection}