Skip to content

Commit

Permalink
feat: add solana to beta (#30613)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Moving solana code fences to `beta`

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30613?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
aganglada authored Feb 27, 2025
1 parent ebc6f30 commit e1444c9
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions app/scripts/metamask-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@ const environmentMappingForRemoteFeatureFlag = {
const buildTypeMappingForRemoteFeatureFlag = {
flask: DistributionType.Flask,
main: DistributionType.Main,
beta: 'beta',
};

export default class MetamaskController extends EventEmitter {
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/metamask-controller.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4204,7 +4204,7 @@ describe('MetaMaskController', () => {
});

it('returna config when not matching default mapping', async () => {
process.env.METAMASK_BUILD_TYPE = 'beta';
process.env.METAMASK_BUILD_TYPE = 'non-existent-distribution';
process.env.METAMASK_ENVIRONMENT = ENVIRONMENT.RELEASE_CANDIDATE;

const result =
Expand Down
3 changes: 3 additions & 0 deletions builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ buildTypes:
features:
- build-beta
- keyring-snaps
- multichain
- solana
- solana-swaps
env:
- INFURA_BETA_PROJECT_ID
- SEGMENT_BETA_WRITE_KEY
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/snaps/test-snap-uilinks.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ describe('Test Snap UI Links', function () {

// check that the correct page has been opened
await driver.waitForSelector({
text: 'Most Popular',
text: 'Most popular',
tag: 'h2',
});

Expand Down

0 comments on commit e1444c9

Please sign in to comment.