Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Bridge throws an uncaught metrics error on tx completion #30842

Closed
micaelae opened this issue Mar 6, 2025 · 1 comment · Fixed by #30848
Closed

[Bug]: Bridge throws an uncaught metrics error on tx completion #30842

micaelae opened this issue Mar 6, 2025 · 1 comment · Fixed by #30848
Assignees
@micaelae
Labels
regression-RC-12.14.0 Regression bug that was found in release candidate (RC) for release 12.14.0 release-12.15.0 Issue or pull request that will be included in release 12.15.0 Sev2-normal Normal severity; minor loss of service or inconvenience.

Comments

@micaelae
Copy link
Member

micaelae commented Mar 6, 2025

Describe the bug

The Bridge experience emits a metric event on tx success. The transaction shows the accurate status but fails to emit an event due to a chainId parsing issue

Expected behavior

No response

Screenshots/Recordings

Image

Steps to reproduce

  1. Open background logs
  2. Submit an EVM<>EVM bridge transaction
  3. Wait for success status
  4. Search for uncaught "Invalid cross-chain swaps chainId" in logs

Error messages or log output



Detection stage


During release testing


Version


12.14.0


Build type


None


Browser


Chrome


Operating system


MacOS


Hardware wallet


No response


Additional context


No response


Severity


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @micaelae
micaelae




          added
  the 

  type-bug

  Something isn't working
 label


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be triaged
  in Bugs by team


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by severity


      Mar 6, 2025

    

  



    


    

    

      
    

    


      

          @micaelae
micaelae




        changed the title
[Bug]: Bridge throws an uncaught metrics error on submission

[Bug]: Bridge throws an uncaught metrics error on tx completion


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




            added
      

  regression-RC-12.14.0

  Regression bug that was found in release candidate (RC) for release 12.14.0

      

  needs-triage

  Issue needs to be triaged

  labels


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @micaelae
micaelae




            removed
      

  type-bug

  Something isn't working

      

  needs-triage

  Issue needs to be triaged

  labels


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  needs-triage

  Issue needs to be triaged
 label


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @micaelae
micaelae




            added
      

  sev-2


    and removed
      

  needs-triage

  Issue needs to be triaged

  labels


      Mar 6, 2025

    

  








      

  
      



  

  @micaelae





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  Author


  


  

    

      

      
            micaelae
  

      

      

      commented


        Mar 6, 2025


      
    


  





      


        


  
    

      
          
Setting severity to sev2 since it affects metrics and monitoring

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @gauthierpetetin
gauthierpetetin




            added
      

  Sev2-normal

  Normal severity; minor loss of service or inconvenience.

    and removed
      

  sev-2


  labels


      Mar 6, 2025

    

  



    

    

      
    

    


      

          @micaelae
micaelae




              self-assigned this


      Mar 6, 2025

    

  



  

  

    
  


  

      

    @micaelae
micaelae



    mentioned this issue
    
      Mar 7, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




  


  
    
  
  

    
  github-merge-queue bot

      pushed a commit
      that referenced
      this issue

    
      Mar 7, 2025
    
    

      


  

    

      


  

      
        @micaelae
      
        @ghgoodreau
  





      

        
          fix: formatChainIdToHex fails to parse evm caip chainIds (#30848)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          48ef8da
        
      

    

  

    

      
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Action Completed metric event requires parsing a caip chainId to hex.
This fails due to incorrectly checking the type of the CAIP reference
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30848?quickstart=1)

## **Related issues**

Fixes: #30842

## **Manual testing steps**

1. Open background logs
2. Submit a bridge tx
3. Check that `batch` network call for "Action Completed" is POSTed

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: hunty <[email protected]>

    




    

  




    

    


    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  release-12.15.0

  Issue or pull request that will be included in release 12.15.0
 label


      Mar 7, 2025

    

  












  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @micaelae
  
    micaelae
    

      








      


  


  

    Labels
  



    

      

    regression-RC-12.14.0

  Regression bug that was found in release candidate (RC) for release 12.14.0
  

    release-12.15.0

  Issue or pull request that will be included in release 12.15.0
  

    Sev2-normal

  Normal severity; minor loss of service or inconvenience.








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs by severity
        
    

    

      

          

  

    
      Archived in project



      

    

    

  



        
  

    

      
          
        Bugs by team
        
    

    

      

            
    Status: To be triaged

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
  
Successfully merging a pull request may close this issue.





    


  
          
      fix: formatChainIdToHex fails to parse evm caip chainIds

    
      MetaMask/metamask-extension
    





      
    

  




      

    

  
      

  

    

      3 participants
    

    

        
          @gauthierpetetin 
        
          @metamaskbot 
        
          @micaelae