fix: formatChainIdToHex fails to parse evm caip chainIds

[micaelae]

Description

Action Completed metric event requires parsing a caip chainId to hex. This fails due to incorrectly checking the type of the CAIP reference

Related issues

Fixes: #30842

Manual testing steps

1. Open background logs
2. Submit a bridge tx
3. Check that batch network call for "Action Completed" is POSTed

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [4916f3d]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1828 ± 48 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	665	2000	1758	264	127
		domContentLoaded	1659	2049	1802	100	48
		load	1678	2063	1828	100	48
		domInteractive	15	156	55	36	17
		backgroundConnect	11	93	28	22	11
		firstReactRender	15	76	36	23	11
		getState	6	61	23	21	10
		initialActions	0	1	0	0	0
		loadScripts	1244	1579	1368	87	42
		setupStore	8	60	16	16	8
		uiStartup	1920	2403	2092	122	58

[metamaskbot]

Builds ready [2d2bdbd]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1961 ± 104 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	526	2391	1888	374	180
		domContentLoaded	1629	2319	1909	189	91
		load	1652	2458	1961	217	104
		domInteractive	26	117	49	28	14
		backgroundConnect	10	254	54	54	26
		firstReactRender	14	102	34	24	12
		getState	6	109	28	26	13
		initialActions	0	1	0	0	0
		loadScripts	1209	1711	1456	148	71
		setupStore	7	62	26	20	10
		uiStartup	1829	3512	2282	352	169

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: -101 Bytes (-0.00%)