Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(2916): refactor stream handler for phishing warning and legacy #26441

Closed
wants to merge 1 commit into from

Conversation

DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented Aug 15, 2024

Description

As part of https://github.com/MetaMask/MetaMask-planning/issues/2916, it is cleaner to extract the stream out of contentscript file and re-use the logic of phishing stream before implement a new stream.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2916

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica DDDDDanica added the team-extension-platform Extension Platform team label Aug 15, 2024
@DDDDDanica DDDDDanica self-assigned this Aug 15, 2024
@DDDDDanica DDDDDanica requested a review from a team as a code owner August 15, 2024 14:30
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@DDDDDanica DDDDDanica force-pushed the chore/refactor-stream branch 4 times, most recently from 1e3e136 to fc8425b Compare August 19, 2024 16:26
@DDDDDanica DDDDDanica force-pushed the chore/refactor-stream branch from fc8425b to bf0f92f Compare August 19, 2024 21:22
Copy link

@DDDDDanica
Copy link
Contributor Author

closed due to unknown reason of failed e2e test. start from a clean up-to-date branch and opened PR here
#26526

@DDDDDanica DDDDDanica closed this Aug 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
@DDDDDanica DDDDDanica deleted the chore/refactor-stream branch August 19, 2024 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant