-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Snap Address component UI/UX (Snaps custom UI) #26477
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26477 +/- ##
========================================
Coverage 69.96% 69.97%
========================================
Files 1405 1405
Lines 48996 48998 +2
Branches 13697 13699 +2
========================================
+ Hits 34280 34282 +2
Misses 14716 14716 ☔ View full report in Codecov by Sentry. |
Builds ready [23331d5]
Page Load Metrics (73 ± 10 ms)
Bundle size diffs
|
31bebad
to
4492e21
Compare
4492e21
to
de76f97
Compare
|
Builds ready [de76f97]
Page Load Metrics (84 ± 9 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change look good, will be nicer to have unit test coverage also.
Description
Because of concerns around Snap custom UI address component not working as intended with Pet Names, decision was made to disable it's interactive UX and display shortened hexadecimal address instead of showing Pet name.
Changes on this PR will make Address component to ignore clicks and triggering the modal for nicknames.
Changes are applied only to Snaps related flows where Snaps components (custom UI) are used.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2965
Manual testing steps
Screenshots/Recordings
Before
After
Customized Interactive UI Snap for the test case, just for reference:

Pre-merge author checklist
Pre-merge reviewer checklist