Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NetworkChangeToast width in wide screen mode #26532

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Aug 20, 2024

Description

Network change toast looks broken in wide screen

Related issues

Fixes: #26527

Manual testing steps

  1. Open MM in full screen mode, switch betweem networks submitting transactions
  2. Network change toast should appear in correct width

Screenshots/Recordings

Screenshot 2024-08-20 at 2 34 26 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested a review from a team as a code owner August 20, 2024 09:10
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Aug 20, 2024
matthewwalsh0
matthewwalsh0 previously approved these changes Aug 20, 2024

@media screen and (min-width: 576px) {
.toast_wrapper {
max-width: 408px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but do we have SCSS variables for either of these numbers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find for with, but there was one for breakpoint which I added.

matthewwalsh0
matthewwalsh0 previously approved these changes Aug 20, 2024
Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [1a2a4fe]
Page Load Metrics (71 ± 8 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7313699189
domContentLoaded3810868209
load4510871178
domInteractive94724105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (81af2e8) to head (1a2a4fe).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26532   +/-   ##
========================================
  Coverage    69.96%   69.96%           
========================================
  Files         1405     1405           
  Lines        48996    48996           
  Branches     13697    13697           
========================================
  Hits         34280    34280           
  Misses       14716    14716           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri merged commit 111f170 into develop Aug 20, 2024
78 checks passed
@jpuri jpuri deleted the network_switch_toast branch August 20, 2024 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 20, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Toast message if user quickly sends transaction on another network - Expanded View
5 participants