-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NetworkChangeToast width in wide screen mode #26532
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
||
@media screen and (min-width: 576px) { | ||
.toast_wrapper { | ||
max-width: 408px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but do we have SCSS variables for either of these numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find for with, but there was one for breakpoint which I added.
|
Builds ready [1a2a4fe]
Page Load Metrics (71 ± 8 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26532 +/- ##
========================================
Coverage 69.96% 69.96%
========================================
Files 1405 1405
Lines 48996 48996
Branches 13697 13697
========================================
Hits 34280 34280
Misses 14716 14716 ☔ View full report in Codecov by Sentry. |
Description
Network change toast looks broken in wide screen
Related issues
Fixes: #26527
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist