Multichain E2E Test: Multi dapp #29751
Open
+16,098
−4,351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** * Binds the `updateCaveat` and `grantPermission` hooks provided to the rpc middleware handlers to the origin of the request * Cleans up resulting usage and unused params [](https://codespaces.new/MetaMask/metamask-extension/pull/29174?quickstart=1) ## **Related issues** See: #27847 (comment) ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Work for integrating [CAIP294](https://github.com/ffmcgee725/caip294-diagram/blob/main/instructions.md) feat: programatically send extensionId in metamask_getProviderState For testing this, we make a call json rpc call to `metamask_getProviderState` and check if response data contains the `extensionId` <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/29111?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Remove `BARAD_DUR` env var and move into Flask code fence [](https://codespaces.new/MetaMask/metamask-extension/pull/29003?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…o caip25-permission-migration
… into jl/caip-multichain-migrate-core
…29166) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Adopts `@metamask/mutlichain` changes that move validation logic out of the CAIP-25 permission and into the caveat itself. [](https://codespaces.new/MetaMask/metamask-extension/pull/29166?quickstart=1) ## **Related issues** Core: MetaMask/core#5064 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** * Adds `requestPermittedChainsPermission`, `requestPermittedChainsPermissionIncremental`, and `requestCaip25Permission` methods to `MetamaskController` * Uses these new hooks in `wallet_requestPermissions`, `eth_requestAccounts`, `wallet_switchEthereumChain`, `wallet_addEthereumChain` * Removes `wallet_requestPermissions` update caveat flow * Make `wallet_requestPermissions` no longer support anything but `eth_requestAccounts` and `endowment:permittedChains` [](https://codespaces.new/MetaMask/metamask-extension/pull/29213?quickstart=1) ## **Related issues** See: #27847 (comment) ## **Manual testing steps** Only user facing change is that `wallet_requestPermissions` should correctly replace instead update existing permissions again ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Alex Donesky <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
…o caip25-permission-migration
… into jl/caip-multichain-migrate-core
jiexi
reviewed
Jan 17, 2025
… into jl/caip-multichain-migrate-core
Builds ready [ee1029b]
Page Load Metrics (1655 ± 64 ms)
|
jiexi
reviewed
Jan 28, 2025
Comment on lines
+35
to
+42
| dappPath: path.join( | ||
| '..', | ||
| '..', | ||
| 'node_modules', | ||
| '@metamask', | ||
| 'test-dapp-multichain', | ||
| 'build', | ||
| ), |
](https://codespaces.new/MetaMask/metamask-extension/pull/29174?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/29111?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/29003?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/29166?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/29213?quickstart=1){kind=link}
There was a problem hiding this comment.
did we have a constant for this somewhere already?
There was a problem hiding this comment.
We had a constant for this for single dapp setup, it's slightly different for multi dapp setup
jiexi
reviewed
Jan 28, 2025
Comment on lines
83
to
87
| await initCreateSessionScopes(driver, [SCOPE], ACCOUNTS); | ||
| await addAccountInWalletAndAuthorize(driver); | ||
| await driver.clickElement({ text: 'Connect', tag: 'button' }); | ||
| await driver.delay(largeDelayMs); | ||
| await driver.switchToWindowWithUrl(dapp); |
There was a problem hiding this comment.
is this create session necessary given the fixtures?
There was a problem hiding this comment.
removed in 9638656, does not seem necessary for read operations test
jiexi
reviewed
Jan 28, 2025
Comment on lines
+152
to
+154
| await initCreateSessionScopes(driver, [SCOPE], ACCOUNTS); | ||
| await addAccountInWalletAndAuthorize(driver); | ||
| await driver.clickElement({ text: 'Connect', tag: 'button' }); |
There was a problem hiding this comment.
same question about if this manual connection is needed since the fixture includes accounts
There was a problem hiding this comment.
If I don't manually create sessions in this second one, when calling eth_sendTransaction downstream the wallet extension UI is not popping up for some reason, causing the test to fail 🤔
There was a problem hiding this comment.
This one seems quite flaky, it's sometimes failing on CI (but passing locally) with a StaleElementReferenceError: stale element reference: stale element not found in the current frame which is weird. I may need to re-visit this implementation for a more consistent reliable approach
jiexi
reviewed
Jan 28, 2025
test/e2e/flask/multichain-api/multi-dapp-wallet_invokeMethod.spec.ts
Outdated
Show resolved
Hide resolved
Builds ready [ea96578]
Page Load Metrics (1605 ± 69 ms)
|
|
Fixes this issue: https://github.com/MetaMask/MetaMask-planning/issues/3897 |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- test: multi dapp e2e test setup;
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist