-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Skeleton to Snaps UI components #29764
Merged
Merged
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
david0xd
force-pushed
the
dd/add-skeleton-snaps-ui
branch
from
January 16, 2025 20:13
cb6ae47
to
38dd785
Compare
Builds ready [ac0d545]
Page Load Metrics (1661 ± 67 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [05f71fb]
Page Load Metrics (1830 ± 79 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
david0xd
added a commit
to MetaMask/snaps
that referenced
this pull request
Jan 20, 2025
### Add Skeleton component. Related PR in extension: MetaMask/metamask-extension#29764 #### Code example JSX code used for testing: ```typescript <Container> <Box> <Text>Skeleton inside text component:</Text> <Text> <Skeleton /> </Text> <Text>Classic Skeleton inside a box:</Text> <Skeleton /> <Text>Top level Skeleton: </Text> <Skeleton height={32} width="100%" /> <Skeleton height={16} width="50%" borderRadius="none" /> <Skeleton height={16} width="25%" borderRadius="medium" /> <Skeleton height={32} width={32} borderRadius="full" /> <Text>Skeleton inside Section: </Text> <Section> <Skeleton height={32} width="100%" /> <Skeleton height={16} width="50%" borderRadius="none" /> <Skeleton height={16} width="25%" borderRadius="medium" /> <Skeleton height={32} width={32} borderRadius="full" /> </Section> <Text>Skeleton inside Row: </Text> <Row label="Row"> <Skeleton height={22} width="30%" /> </Row> <Row label="Row"> <Text> <Skeleton height={22} width={40} /> </Text> </Row> </Box> </Container> ``` #### Screenshots ![Screenshot 2025-01-17 at 13 09 22](https://github.com/user-attachments/assets/7ebd5646-6664-4b72-8578-33e7db6557a5)
david0xd
force-pushed
the
dd/add-skeleton-snaps-ui
branch
from
January 27, 2025 11:12
05f71fb
to
5ca813f
Compare
david0xd
force-pushed
the
dd/add-skeleton-snaps-ui
branch
from
January 27, 2025 11:13
5ca813f
to
0d43ddd
Compare
FrederikBolding
force-pushed
the
fb/snaps-bump-v85
branch
from
January 27, 2025 11:17
fa3505a
to
2ccd0b6
Compare
david0xd
force-pushed
the
dd/add-skeleton-snaps-ui
branch
from
January 27, 2025 11:20
0d43ddd
to
31eb598
Compare
ui/components/app/snaps/snap-ui-renderer/components/skeleton.ts
Outdated
Show resolved
Hide resolved
ui/components/app/snaps/snap-ui-renderer/components/skeleton.ts
Outdated
Show resolved
Hide resolved
david0xd
force-pushed
the
dd/add-skeleton-snaps-ui
branch
from
January 27, 2025 13:28
9bfc50c
to
cf69e36
Compare
FrederikBolding
approved these changes
Jan 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Skeleton to Snaps UI components.
Related issues
Fixes: MetaMask/snaps#2940
Related Pull Requests
Snaps PR: MetaMask/snaps#3024
Manual testing steps
Snap UI JSX code used for testing:
Screenshots/Recordings
Before
Skeleton was not available before. Nothing to show here.
After
Pre-merge author checklist
Pre-merge reviewer checklist