Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bug in transaction flow component for 1155 token #29775

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Jan 17, 2025

Description

There has been a recent change to stop relying on transaction decoding third parties. The parsed transaction data now varies depending on the ABIs, and for some ERC1155 tokens the ._to argument is expressed as simply .to.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screenshot 2025-01-17 at 10 03 10

After

Screenshot 2025-01-17 at 10 05 45

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Jan 17, 2025
@pedronfigueiredo pedronfigueiredo self-assigned this Jan 17, 2025
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner January 17, 2025 10:26
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [958ee77]
Page Load Metrics (1851 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22822941677466224
domContentLoaded15792209182016680
load15882274185116680
domInteractive26160473014
backgroundConnect766282210
firstReactRender1680372411
getState65922199
initialActions01000
loadScripts11471701137213967
setupStore615821
uiStartup17672540209919091
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 239 Bytes (0.00%)
  • ui: 1.87 KiB (0.02%)
  • common: -621 Bytes (-0.01%)

Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: if possible will be nice to test cover this

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 8bfbc78 Jan 23, 2025
78 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/fix-1155-bug branch January 23, 2025 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants