Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds fiat value to the swap totoken display #29788

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ghgoodreau
Copy link
Contributor

@ghgoodreau ghgoodreau commented Jan 17, 2025

Description

This change will show the user the fiat amount of the balance of the token they are swapping to. This is useful for understanding price impact a bit better.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1854

Manual testing steps

  1. Go to the swaps page in exension.
  2. Try to swap a token.
  3. Observe the fiat value displayed and that it is correct.

Screenshots/Recordings

Before

Screenshot 2025-01-17 at 12 48 59 PM

After

Screenshot 2025-01-17 at 12 48 03 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [43bf00b]
Page Load Metrics (1778 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26819321555537258
domContentLoaded13861893174913565
load13951929177813465
domInteractive268346199
backgroundConnect75823178
firstReactRender1574332010
getState57416189
initialActions01000
loadScripts9961484129212460
setupStore658202010
uiStartup15712161201314570
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 319 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants