Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi srp mvp #29794

Draft
wants to merge 51 commits into
base: main
Choose a base branch
from
Draft

Multi srp mvp #29794

wants to merge 51 commits into from
+1,856 −102

Conversation

PatrykLucka
Copy link
Contributor

@PatrykLucka PatrykLucka commented Jan 18, 2025 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

PatrykLucka and others added 30 commits December 11, 2024 13:59
@PatrykLucka
feat: multip SRP PoC
ce87824
@PatrykLucka
feat(multi-srp): add keyring id
5b9bf58
@PatrykLucka
chore(multi-srp): add code fences
cc9cd94
@PatrykLucka
chore(multi-srp): add import codefence, tests and story
ae06ccf
@PatrykLucka
chore(multi-srp): change js component to tsx + use accountController …
9771fe5 
…instead of preferencesController
@PatrykLucka
feat(multi-srp): add more accounts from imported SRP if they have any…
33740d1 
… balance
@PatrykLucka @montelaidev
Apply suggestions from code review
ef4d9e2 
Co-authored-by: Monte Lai <[email protected]>
@PatrykLucka
chore: Apply suggestions from code review
a2a07db
@PatrykLucka
feat(multi-srp): use toast as success message
8c01287
@PatrykLucka
chore: use preview build for keyring-controller
c169e2b
@montelaidev
fix: update to pass typeIndex as param
a5cfec3
@PatrykLucka
feat(multi-srp): add select srp UI
c26ac36
@montelaidev
feat: add test for reveal seed
4648cd9
@montelaidev
feat: add generateNewHdKeyring
491e3bb
@PatrykLucka
feat(multi-srp): create account from srp UI
b62d838
@PatrykLucka
Merge branch 'mmmsrp-9' into multi-srp-mvp
edc978f
@PatrykLucka
refactor: use keyring index instead of id and typeIndex
ff891e0
@montelaidev
feat: add import srp word list ui
2e69c3b
@PatrykLucka
feat: multip SRP PoC
b3b1522
@PatrykLucka
feat(multi-srp): add keyring id
6824d52
@PatrykLucka
chore(multi-srp): add code fences
6fc4744
@PatrykLucka
chore(multi-srp): add import codefence, tests and story
e904582
@PatrykLucka
chore(multi-srp): change js component to tsx + use accountController …
c5d819a 
…instead of preferencesController
@PatrykLucka
feat(multi-srp): add more accounts from imported SRP if they have any…
1cd827b 
… balance
@PatrykLucka @montelaidev
Apply suggestions from code review
d18fd69 
Co-authored-by: Monte Lai <[email protected]>
@PatrykLucka
chore: Apply suggestions from code review
f16ae0a
@PatrykLucka
feat(multi-srp): use toast as success message
a26d104
@PatrykLucka
chore: use preview build for keyring-controller
8e612fc
@PatrykLucka
feat(multi-srp): add select srp UI
2013282
@PatrykLucka
feat(multi-srp): create account from srp UI
079bffe
montelaidev and others added 21 commits January 16, 2025 10:35
@montelaidev @PatrykLucka
fix: update to pass typeIndex as param
5c47583
@montelaidev @PatrykLucka
feat: add test for reveal seed
c1adf77
@montelaidev @PatrykLucka
feat: add generateNewHdKeyring
3992ba1
@PatrykLucka
refactor: use keyring index instead of id and typeIndex
315d3fe
@PatrykLucka
feat: multip SRP PoC
8c7fc6a
@PatrykLucka
feat(multi-srp): add keyring id
6eb0458
@PatrykLucka
chore(multi-srp): add code fences
50f0adf
@PatrykLucka
chore(multi-srp): add import codefence, tests and story
5c4c6af
@PatrykLucka
chore(multi-srp): change js component to tsx + use accountController …
8a09e41 
…instead of preferencesController
@PatrykLucka
feat(multi-srp): add more accounts from imported SRP if they have any…
f51517f 
… balance
@PatrykLucka @montelaidev
Apply suggestions from code review
b62fb4d 
Co-authored-by: Monte Lai <[email protected]>
@PatrykLucka
chore: Apply suggestions from code review
d47b04f
@PatrykLucka
feat(multi-srp): use toast as success message
1c5c968
@PatrykLucka
chore: use preview build for keyring-controller
c9f121c
@PatrykLucka
feat(multi-srp): create account from srp UI
b940893
@montelaidev @PatrykLucka
fix: update to pass typeIndex as param
39e66a0
@PatrykLucka
refactor: use keyring index instead of id and typeIndex
4019541
@montelaidev @PatrykLucka
feat: add reveal srp to hd accounts.
816069a
@montelaidev @PatrykLucka
fix: multisrp fence
2470ec7
@PatrykLucka
Merge branch 'multi-srp-mvp-import-srp-ui' into multi-srp-mvp
55e184b
@PatrykLucka
feat(multi-srp): use keyringId instead of indexes
3332a8d
@PatrykLucka PatrykLucka self-assigned this Jan 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@PatrykLucka PatrykLucka mentioned this pull request Jan 18, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PatrykLucka PatrykLucka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrykLucka @montelaidev