Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update accounts deps #29867

Merged
merged 7 commits into from
Jan 23, 2025
Merged

chore: update accounts deps #29867

merged 7 commits into from
Jan 23, 2025

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Jan 23, 2025

Description

Bumping accounts related packages. This align the keyring-api version everywhere. This new version introduces the listAccountAssets keyring method.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ccharly ccharly changed the title Chore/update accounts deps chore: update accounts deps Jan 23, 2025
@ccharly ccharly force-pushed the chore/update-accounts-deps branch from 2a1814e to 5f9cd4e Compare January 23, 2025 09:51
@metamaskbot
Copy link
Collaborator

Builds ready [1838a57]
Page Load Metrics (1708 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23718291575450216
domContentLoaded1505181216918239
load1518186517088842
domInteractive247541199
backgroundConnect74420105
firstReactRender1699442713
getState459222210
initialActions01000
loadScripts1057135812457636
setupStore65216178
uiStartup17842634200016981
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 684 Bytes (0.01%)

@ccharly ccharly marked this pull request as ready for review January 23, 2025 10:45
@ccharly
Copy link
Contributor Author

ccharly commented Jan 23, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot metamaskbot requested review from a team as code owners January 23, 2025 11:23
@metamaskbot
Copy link
Collaborator

Builds ready [5948106]
Page Load Metrics (2399 ± 193 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31738192077922443
domContentLoaded166233942365392188
load166634002399402193
domInteractive34316876029
backgroundConnect788332311
firstReactRender18163643215
getState599312612
initialActions01000
loadScripts119524941803329158
setupStore74415126
uiStartup182144122786536258
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 40.17 KiB (0.44%)

darioAnongba
darioAnongba previously approved these changes Jan 23, 2025
danroc
danroc previously approved these changes Jan 23, 2025
@ccharly ccharly added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 23, 2025
@ccharly ccharly dismissed stale reviews from danroc and darioAnongba via 71eeefc January 23, 2025 14:58
@ccharly
Copy link
Contributor Author

ccharly commented Jan 23, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

Builds ready [f026673]
Page Load Metrics (1709 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15371913170711354
domContentLoaded15201881167710249
load15351894170911354
domInteractive219138199
backgroundConnect885292612
firstReactRender1582382412
getState45117178
initialActions01000
loadScripts1079138712128139
setupStore685172411
uiStartup174526411999235113
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 40.17 KiB (0.44%)

@ccharly ccharly added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 009ad97 Jan 23, 2025
71 checks passed
@ccharly ccharly deleted the chore/update-accounts-deps branch January 23, 2025 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants