feat: Remove 'confirmation redesign' developer settings toggle

[pedronfigueiredo]

Description

• Delete Confirmations Redesign developer options settings toggle.
• Delete corresponding selector and action.
• Delete isRedesignedConfirmationsDeveloperEnabled preferences state property with a migration.
• Remove usage of ENABLE_CONFIRMATION_REDESIGN environment variable.
• Adjusted tests

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3708

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [a273115]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1689 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1514	2108	1695	159	77
		domContentLoaded	1493	1924	1658	125	60
		load	1521	1979	1689	132	63
		domInteractive	24	105	46	23	11
		backgroundConnect	8	85	32	25	12
		firstReactRender	16	97	37	26	12
		getState	5	95	14	19	9
		initialActions	0	1	0	0	0
		loadScripts	1073	1481	1226	105	50
		setupStore	7	90	14	20	10
		uiStartup	1705	2726	1950	237	114

Bundle size diffs [🚀 Bundle size reduced!]

• background: 48.14 KiB (0.82%)
• ui: -287 Bytes (-0.00%)
• common: -363.74 KiB (-4.00%)

[digiwand]

awesome!