-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Snap Section
component overflow
#29882
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [bfbce8e]
Page Load Metrics (1697 ± 111 ms)
Bundle size diffs
|
Builds ready [941fb9e]
Page Load Metrics (1733 ± 62 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the changes locally and working as expected and code LGTM!
@@ -49,5 +50,6 @@ export const box: UIComponentFactory<BoxElement> = ({ | |||
alignItems: element.props.center && AlignItems.center, | |||
className: 'snap-ui-renderer__panel', | |||
color: TextColor.textDefault, | |||
flexWrap: FlexWrap.Wrap, // ensures components can wrap horizontally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both this change and the flex
change will have impact beyond the overflow we are trying to fix here.
Have you tested existing Snap UI's to make sure this doesn't cause regressions in behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I tested it with the box being vertical and behavior was unchanged. If you're talking about regressions across all existing snap interfaces (examples and production snaps), no -- that's a lot to check. This and other work has made me think if we should have some service that checks for regressions programmatically, realistically any UI change can break an existing snap interface.
Builds ready [1daff52]
Page Load Metrics (1735 ± 72 ms)
Bundle size diffs
|
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
flex-wrap: wrap
is applied to the section (box) component and that each text component has horizontal space withflex: 1
.Related issues
Fixes: #29876
Manual testing steps
Screenshots/Recordings
Before
See issue
After
Pre-merge author checklist
Pre-merge reviewer checklist