fix: Perf: Prevent MultichainMetaFoxLogo from multiple renders

[darkwing]

Description

The MultichainMetaFoxLogo component rerenders because we aren't using useCallback for the onClick. This continues to happen even after logged in.

Related issues

Fixes:

Manual testing steps

1. Start the extension with ENABLE_WHY_DID_YOU_RENDER=1 yarn start
2. Don't see rerenders on the MultichainMetaFoxLogo

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [b805fca]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1663 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1432	1962	1663	152	73
		domContentLoaded	1415	1899	1639	146	70
		load	1437	1959	1663	149	72
		domInteractive	22	164	45	34	16
		backgroundConnect	10	70	30	20	10
		firstReactRender	15	79	42	25	12
		getState	4	58	15	16	8
		initialActions	0	1	0	0	0
		loadScripts	968	1455	1180	129	62
		setupStore	6	56	13	13	6
		uiStartup	1604	2296	1888	185	89

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 581 Bytes (0.01%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [ce494e8]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1470 ± 42 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1351	1630	1473	86	41
		domContentLoaded	1335	1619	1455	85	41
		load	1345	1629	1470	88	42
		domInteractive	22	92	45	22	10
		backgroundConnect	10	47	24	13	6
		firstReactRender	14	64	26	19	9
		getState	4	50	10	12	6
		initialActions	0	1	0	0	0
		loadScripts	948	1224	1086	81	39
		setupStore	7	47	10	9	4
		uiStartup	1491	1870	1663	96	46

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 581 Bytes (0.01%)
• common: 0 Bytes (0.00%)

[vinnyhoward]

LGTM

[metamaskbot]

Builds ready [a51e43c]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1541 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	482	1829	1495	261	125
		domContentLoaded	1349	1743	1521	103	50
		load	1362	1838	1541	113	54
		domInteractive	23	69	28	10	5
		backgroundConnect	8	98	29	21	10
		firstReactRender	14	69	29	22	10
		getState	4	45	11	12	6
		initialActions	0	1	0	0	0
		loadScripts	980	1286	1126	85	41
		setupStore	7	52	11	10	5
		uiStartup	1531	2231	1749	149	72

[metamaskbot]

Builds ready [53d345d]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (2008 ± 105 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	511	2490	1847	473	227
		domContentLoaded	1691	2407	1967	220	106
		load	1717	2478	2008	219	105
		domInteractive	26	186	53	42	20
		backgroundConnect	15	101	44	25	12
		firstReactRender	15	84	35	21	10
		getState	7	84	27	22	10
		initialActions	0	1	0	0	0
		loadScripts	1265	1953	1500	201	97
		setupStore	8	55	18	16	8
		uiStartup	1959	2926	2298	262	126

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 581 Bytes (0.01%)
• common: 0 Bytes (0.00%)